-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default accounts in integration test implementation #1955
Open
ramirez7358
wants to merge
19
commits into
use-ink:master
Choose a base branch
from
CoinFabrik:default-accounts-in-integration-test-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Default accounts in integration test implementation #1955
ramirez7358
wants to merge
19
commits into
use-ink:master
from
CoinFabrik:default-accounts-in-integration-test-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramirez7358
requested review from
cmichi,
ascjones and
SkymanOne
as code owners
October 27, 2023 18:46
10 tasks
Merged
@ramirez7358 Could you merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1953
cargo-contract
orpallet-contracts
?Description
Function
default_accounts()
Initial Status
Implementation Difference
Issue Description
Default accounts addresses do not match across integration and e2e tests.
Issue Documentation & Test Case
https://github.com/CoinFabrik/on-ink-integration-tests/tree/main/test-cases/default-accounts
Current Status
Implementation Difference Corrected. Test Cases in Target Repo Passed. Pull Request Performed to Corresponding Repository.
Implementation Notes
Now the integration tests mimic the account setup in e2e tests. We changed the name of the accounts "Django" to "Dave" and "Frank" to "Ferdie". On the other hand, there were two accounts in e2e that did not exist in integration tests, accounts “one” and “two”. We added these accounts to integration tests.
Moreover, since e2e tests were drawing these accounts from the library
sp_keyring::sr25519::Keyring
, we made integration tests depend on the same library in order to account for future changes in this lib.Updated Documentation
We updated the original documentation of this issue in our repository, adding the section Update on Correcting this Issue and informing of the correction.
In the target repository, we updated the inline documentation. The associated documentation should be updated automatically in these pages: ink_env test default_accounts, ink_env test DefaultAccounts, ink_e2e AccountKeyring.
Testing Guide
In the directory
integration-tests/default_accounts
of the target directory, we include in our pull request a test case showing that the observed implementation difference has been corrected. Note that this test is different from the original test case in our repo, which showed the implementation difference.In this directory
integration-tests/default_accounts
, run the following command to run both integration and e2e tests:cargo test -–features e2e-tests
These tests are run in the same function in order to compare the results of both environments.
Checklist before requesting a review
CHANGELOG.md